Open
Conversation
collijk
reviewed
Mar 28, 2025
| self._root = Path(root) | ||
| self._credentials_root = self._root / "credentials" | ||
| self._read_only = read_only | ||
| if not read_only: |
Member
There was a problem hiding this comment.
You don't want this here. The flooding directory is always read-only in this repository. I have it for the ClimateData class because this repo has pipeline stages where climate data is an output directory and other stages that only consume from the climate data and write to the aggregates directory.
collijk
reviewed
Mar 28, 2025
| read_only: bool = False, | ||
| ) -> None: | ||
| self._root = Path(root) | ||
| self._credentials_root = self._root / "credentials" |
Member
There was a problem hiding this comment.
This object doesn't need credentials. The credentials are for accessing external services (e.g. the ERA5 dbs) or storage we share with partners (e.g. Azure blobs for buildings/populations)
collijk
reviewed
Mar 28, 2025
| def results_metadata(self) -> Path: | ||
| return self.results / "metadata" | ||
|
|
||
| def save_scenario_metadata(self, df: pd.DataFrame) -> None: |
Member
There was a problem hiding this comment.
No save functions on this object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.